This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Go to Type Definition command implementation #2136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @hummerd! @segevfiner Given that you logged #2121, can you try out these changes and give feedback? |
ramya-rao-a
suggested changes
Nov 21, 2018
|
Hmm, I don't understand - github says ramya-rao-a requested changes, but I see no changes in last build. What should I do? |
It's what GitHub says once someone submits a review for your PR until he reviews it again. If you already fixed what was requested of you in the review, than you just need to wait for the code to be reviewed again. |
|
I get it. Thanks! |
segevfiner
reviewed
Nov 21, 2018
ramya-rao-a
reviewed
Nov 22, 2018
ramya-rao-a
approved these changes
Nov 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go to Type Definition command implementation. Works with latest guru with this commit.